[FFmpeg-devel] [PATCH] Electronic Arts TGQ decoder

[Michael Niedermayer]

On Tue, Nov 04, 2008 at 05:18:40PM +1100, Peter Ross wrote:
> On Wed, Oct 08, 2008 at 09:25:03PM +0200, Michael Niedermayer wrote:
> > On Tue, Oct 07, 2008 at 09:53:49PM +1100, Peter Ross wrote:
> > > On Sat, Oct 04, 2008 at 03:19:50AM +0200, Michael Niedermayer wrote:
> > > > On Fri, Oct 03, 2008 at 09:43:51PM +1000, Peter Ross wrote:
> > > > > On Sat, Sep 27, 2008 at 08:07:05PM +1000, Peter Ross wrote:
> > > > > > On Sat, Sep 27, 2008 at 10:12:34AM +1000, Peter Ross wrote:
> > > > > > > Patches enclosed.
> > > > > > > 
> > > > > > > Info: http://wiki.multimedia.cx/index.php?title=Electronic_Arts_TGQ
> > > > > > > Samples: http://samples.mplayerhq.hu/game-formats/ea-tgq-uv/
> > > > > > 
> > > > > > Thanks for the prompt feedback. Round two enclosed.
> > > > > 
> > > > > Round three. (See earlier posts for inv_aanscales.diff and eatgq-demux-r1.diff.)
> > > 
> > > Comments below. Round four enclosed.
> 
> Patch updated; integer DCT now in seperate file.
> 
> > [...]
> > 
> > > +/* Electronic Arts TGQ/TQI/MAD IDCT algorithm */
> > > +#define A4 1.3065630f
> > > +#define A2 0.5411961f
> > > +#define A5 0.3826834f
> > 
> > maybe these should get the following comments:
> > cos(pi*1/16)sqrt(2)
> > cos(pi*2/16)sqrt(2)
> > cos(pi*6/16)sqrt(2)
> 
> Err, don't you mean:
> 
> A4 = 1.3065630f = cos(pi*1/8)*sqrt(2)
> A2 = 0.5411961f = cos(pi*3/8)*sqrt(2)
> A5 = 0.3826834f = cos(pi*3/8)

no i meant
cos(PI/8)*2^.5
sin(PI/8)*2^.5
sin(PI/8)
;)


[...]

> Index: libavcodec/eadct.c

i think it should contain idct in its name

except that patches ok, no need to resubmit!

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081107/9c4f55f6/attachment.pgp>