[FFmpeg-devel] [PATCH]Add RoQ regression tests - stddev improved

Vitor Sessak vitor1001
Sat Nov 1 17:49:55 CET 2008

Mike Melanson wrote:
> Vitor Sessak wrote:
>> Mike Melanson wrote:
>>> Carl Eugen Hoyos wrote:
>>>> Hi!
>>>> Vitor Sessak <vitor1001 <at> gmail.com> writes:
>>>>>>> The patch increases the time of "make test" by about 30%. If you 
>>>>>>> tell me a
>>>>>>> reasonable amount, I'll change the test accordingly and apply.
>>>>>> 1-2%
>>>>>> but it should be at least 2-3 frames
>>>>> Any news on this? Carl, if you are out of time, I don't mind sending 
>>>>> a new patch using the -vframes option...
>>>> I'm happy if you solve it: vframes has to be 15 at least, because (I 
>>>> think, did
>>>> not RTFS) decoder searches 15 frames for audio and fails if they are not
>>> Yes, 15 frames. Until such time I get arround to making the demuxer 
>>> smarter.
>> Do you think the following patch fix it?
> No. It will require a little more substantial rework. The scan approach 
> is completely wrong. The demuxer should just start splitting apart the 
> chunks and sending them to the streams, initializing the streams along 
> the way if not already done. My mistake was in believing that all the 
> streams had to be init'd when the file was first opened.

Are you sure it is not required? What if someone does

$ ffmpeg -i file.roq out.avi

The AVI muxer needs to know if there is an audio stream or not to write 
the header. If the RoQ demuxer only "finds" the audio stream at the 
tenth frame, how will FFmpeg do to write correctly the AVI header?


More information about the ffmpeg-devel mailing list