[FFmpeg-devel] bit func helpers

Michael Niedermayer michaelni
Fri May 30 14:51:53 CEST 2008


On Fri, May 30, 2008 at 02:00:22PM +0200, Andreas ?man wrote:
> Hi
>
> I suggest we move these tiny helpers for dv.c to bitstream.h

Code which is used just by dv stays in dv.

If i disable dv, i dont want these compiled ...
Besides the API is complex enough no need to add to it functions only used
by a single codec.

[...]

> -static inline int get_bits_size(GetBitContext *s)
> -{
> -    return s->size_in_bits;
> -}

I really think dv should use s->size_in_bits instead of this senseless
wraper function but iam not dv maintainer, just my 2 cents ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080530/329b6f67/attachment.pgp>



More information about the ffmpeg-devel mailing list