[FFmpeg-devel] [PATCH] deals with code that has no effect when executed

[Erik Hovland]

On Thu, May 29, 2008 at 11:31:36PM +0200, Michael Niedermayer wrote:
> > diff --git a/libavformat/udp.c b/libavformat/udp.c
> > index effe699..90c134b 100644
> > --- a/libavformat/udp.c
> > +++ b/libavformat/udp.c
> > @@ -290,15 +290,16 @@ int udp_set_remote_url(URLContext *h, const char *uri)
> >  {
> >      UDPContext *s = h->priv_data;
> >      char hostname[256];
> > -    int port;
> > +    int port, addr_len;
> >  
> >      url_split(NULL, 0, NULL, 0, hostname, sizeof(hostname), &port, NULL, 0, uri);
> >  
> >      /* set the destination address */
> > -    s->dest_addr_len = udp_set_url(&s->dest_addr, hostname, port);
> > -    if (s->dest_addr_len < 0) {
> > +    addr_len = udp_set_url(&s->dest_addr, hostname, port);
> 
> dest_addr_len is int so this should not be needed
> I assume you where looking at an old version of ffmpeg?
> 
> [...]

Now was that so hard?

Thanks for looking it over. I had indeed made the change back in April
before the type of dest_addr_len was changed on May 11. Your review was
invaluable.

E

-- 
Erik Hovland
mail: erik at hovland.org
web: http://hovland.org/
PGP/GPG public key available on request