[FFmpeg-devel] [PATCH] remove unnecessary header files

[Erik Hovland]

On Thu, May 29, 2008 at 05:36:06PM +0200, Diego Biurrun wrote:
> On Thu, May 29, 2008 at 05:24:07PM +0200, Michael Niedermayer wrote:
> > On Thu, May 29, 2008 at 05:13:11PM +0200, Diego Biurrun wrote:
> > > On Thu, May 29, 2008 at 07:50:18AM -0700, Erik Hovland wrote:
> > > > On Thu, May 29, 2008 at 03:38:39PM +0200, Diego Biurrun wrote:
> > > > > > -#include "ffserver.h"
> > > > > 
> > > > > Wrong.
> > > > > 
> > > > > > --- a/libavutil/tree.c
> > > > > > +++ b/libavutil/tree.c
> > > > > > @@ -19,7 +19,6 @@
> > > > > >  
> > > > > >  #include "common.h"
> > > > > > -#include "log.h"
> > > > > 
> > > > > Wrong.
> > > > > 
> > > > > I haven't reviewed this completely, but I do not trust the rest of the
> > > > > changes much.  I applied the correct changes that I noted above.
> > > > 
> > > > Oh ye of little faith :)
> > > 
> > > Ummm, just look at tree.c, it uses av_log all over the place, which is
> > > declared in log.h ...
> > > 
> > > After looking again, it seems I was wrong about ffserver.c/ffserver.h.
> > > I will apply that change as well.
> > 
> > Thats what happens when one #includes headers from other headers ...
> > c files just #include random subsets of the headers they need.
> > Without headers #including other headers its
> > compiles -> includes all needed headers, doesnt compile misses a header
> 
> This is not the issue we are discussing here, this is about unnecessary
> headers left lying around...

I think you guys are talking about the same thing. Michael is talking
about how extra headers get left lying around. Not the extra headers
themselves.

E

-- 
Erik Hovland
mail: erik at hovland.org
web: http://hovland.org/
PGP/GPG public key available on request