[FFmpeg-devel] [PATCH] remove unnecessary header files

Michael Niedermayer michaelni
Thu May 29 17:59:29 CEST 2008


On Thu, May 29, 2008 at 05:36:06PM +0200, Diego Biurrun wrote:
> On Thu, May 29, 2008 at 05:24:07PM +0200, Michael Niedermayer wrote:
> > On Thu, May 29, 2008 at 05:13:11PM +0200, Diego Biurrun wrote:
> > > On Thu, May 29, 2008 at 07:50:18AM -0700, Erik Hovland wrote:
> > > > On Thu, May 29, 2008 at 03:38:39PM +0200, Diego Biurrun wrote:
> > > > > > -#include "ffserver.h"
> > > > > 
> > > > > Wrong.
> > > > > 
> > > > > > --- a/libavutil/tree.c
> > > > > > +++ b/libavutil/tree.c
> > > > > > @@ -19,7 +19,6 @@
> > > > > >  
> > > > > >  #include "common.h"
> > > > > > -#include "log.h"
> > > > > 
> > > > > Wrong.
> > > > > 
> > > > > I haven't reviewed this completely, but I do not trust the rest of the
> > > > > changes much.  I applied the correct changes that I noted above.
> > > > 
> > > > Oh ye of little faith :)
> > > 
> > > Ummm, just look at tree.c, it uses av_log all over the place, which is
> > > declared in log.h ...
> > > 
> > > After looking again, it seems I was wrong about ffserver.c/ffserver.h.
> > > I will apply that change as well.
> > 
> > Thats what happens when one #includes headers from other headers ...
> > c files just #include random subsets of the headers they need.
> > Without headers #including other headers its
> > compiles -> includes all needed headers, doesnt compile misses a header
> 
> This is not the issue we are discussing here, this is about unnecessary
> headers left lying around...

Without headers #including other headers i can just outcomment all #includes
from a c file, compile it and gcc will tell me exactly what parts are in need
of a #include. Its very easy and quick to find out what one needs to #include
using that method.

With headers #including other headers how can you know that a #include is
unneeded? gcc wont complain if the #inculde is removed nor will it if it
is there and unused. You end up reading the source and guessing, a
timeconsuming and error prone solution.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080529/2e96c8f2/attachment.pgp>



More information about the ffmpeg-devel mailing list