[FFmpeg-devel] [PATCH] remove unnecessary header files

[Michael Niedermayer]

On Thu, May 29, 2008 at 05:13:11PM +0200, Diego Biurrun wrote:
> On Thu, May 29, 2008 at 07:50:18AM -0700, Erik Hovland wrote:
> > On Thu, May 29, 2008 at 03:38:39PM +0200, Diego Biurrun wrote:
> > > > -#include "ffserver.h"
> > > 
> > > Wrong.
> > > 
> > > > --- a/libavutil/tree.c
> > > > +++ b/libavutil/tree.c
> > > > @@ -19,7 +19,6 @@
> > > >  
> > > >  #include "common.h"
> > > > -#include "log.h"
> > > 
> > > Wrong.
> > > 
> > > I haven't reviewed this completely, but I do not trust the rest of the
> > > changes much.  I applied the correct changes that I noted above.
> > 
> > Oh ye of little faith :)
> 
> Ummm, just look at tree.c, it uses av_log all over the place, which is
> declared in log.h ...
> 
> After looking again, it seems I was wrong about ffserver.c/ffserver.h.
> I will apply that change as well.

Thats what happens when one #includes headers from other headers ...
c files just #include random subsets of the headers they need.
Without headers #including other headers its
compiles -> includes all needed headers, doesnt compile misses a header

Anyway iam not wanting to restart that bikeshed issue, i just wanted
to point out that the work you guys are doing here wouldnt be neccessary.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080529/9a7053cf/attachment.pgp>