[FFmpeg-devel] Strange construct on libavcodec/flicvideo.c

[Michael Niedermayer]

On Wed, May 28, 2008 at 09:12:14AM +0100, David Bolt wrote:
> On Wed, 28 May 2008, Benoit Fouet wrote:-
> 
> >David Bolt wrote:
> >> Index: libavcodec/flicvideo.c
> >> ===================================================================
> >> --- libavcodec/flicvideo.c   (revision 13473)
> >> +++ libavcodec/flicvideo.c   (working copy)
> >> @@ -592,6 +592,7 @@
> >>                  while (pixel_countdown > 0) {
> >>                      *((signed short*)(&pixels[pixel_ptr])) =
> >>AV_RL16(&buf[pixel_ptr]);
> >>                      pixel_ptr += 2;
> >> +                    pixel_countdown--;
> >>                  }
> >>
> >
> >I think this could be merged with the while statement
> 
> It could. New patch attached.

I do not think this patch is correct.
copying the raw compressed data from buf to the image ...

I will disable the code unless someone who understands the surrounding
flic code fixes it.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080528/e98d7051/attachment.pgp>