[FFmpeg-devel] [PATCH] Patches to fix issue453 in libdiracschroedinger

[Diego Biurrun]

On Mon, May 26, 2008 at 10:26:59AM +1000, Anuradha Suraparaju wrote:
> 
> On Fri, 2008-05-23 at 22:15 +0200, Michael Niedermayer wrote:
> > On Thu, May 22, 2008 at 12:26:16PM +1000, Anuradha Suraparaju wrote:
> > > 
> > > -                p_frame_output->frame_num = (enc_buf->data[13] << 24) +
> > > -                                            (enc_buf->data[14] << 16) +
> > > -                                            (enc_buf->data[15] <<  8) +
> > > -                                             enc_buf->data[16];
> > > -            }
> > > +            p_frame_output->frame_num = (schro_buf->data[13] << 24) +
> > > +                                        (schro_buf->data[14] << 16) +
> > > +                                        (schro_buf->data[15] <<  8) +
> > > +                                         schro_buf->data[16];
> > 
> > reindention counts as cosmetic as well
> > so yes the if&assert should be removed and the indention then fixed in a
> > seperate patch, this keeps svnlog and patches more human readable.
> 
> I want to make sure that I understood this correctly. So I remove the if
> & assert in one patch and submit it. Then I fix the indentation and
> other cosmetic changes mentions and submit a second patch. Is this
> correct?

Yes.

Diego