[FFmpeg-devel] [PATCH] qt_faststart: use proper PRI types and more helpful message

Mike Melanson mike
Tue May 27 03:19:36 CEST 2008


Baptiste Coudurier wrote:
> Hi Reimar,
> 
> Reimar D?ffinger wrote:
>> Hello,
>> attached patch adds the encountered atom to the "encountered non-QT
>> top-level atom" message which is very useful for debugging and
>> it changes the llX printf type to the correct "PRIX64" (to be applied in
>> two parts obviously).
>> Comments/objections?
> 
> IMHO it would be better to print atom in a human readable way.

I vote for both. Print out the number and, in parentheses, the 
characters, if they fall in the ASCII range (not always true if the file 
is corrupted).

-- 
	-Mike Melanson




More information about the ffmpeg-devel mailing list