[FFmpeg-devel] [PATCH] issue251, xvid within .ogm will not remux to .avi

Måns Rullgård mans
Mon May 26 08:29:40 CEST 2008


Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> The patch below will fix remuxing from some ogm. Iam not 100% sure that
> this is the correct solution though ...

I believe you, but could you please explain a little.

> Index: libavformat/oggdec.c
> ===================================================================
> --- libavformat/oggdec.c	(revision 13251)
> +++ libavformat/oggdec.c	(working copy)
> @@ -425,7 +425,7 @@
>
>      if(os->codec->gptopts){
>          pts = os->codec->gptopts(s, i, gp);
> -    } else {
> +    } else if(gp){
>          pts = gp;
>      }

If I'm reading this correctly, it will prevent a pts being set on the
first packet of each stream.  This is certainly not correct for normal
(odd thing to call an ogg file, but hey) files.  If ogm requires
special treatment, it should have its own conversion function.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list