[FFmpeg-devel] [PATCH] parse audio in ogm

Måns Rullgård mans
Mon May 26 01:57:28 CEST 2008


Justin Ruggles <justinruggles at bellsouth.net> writes:

> Hi,
>
> This fixes Issue165.  It seems that any type of audio that can be
> wrapped in wav can be wrapped in ogm, and that it does not necessarily
> have exactly one frame per packet.

Hardly surprising.

> Index: libavformat/oggparseogm.c
> ===================================================================
> --- libavformat/oggparseogm.c	(revision 13380)
> +++ libavformat/oggparseogm.c	(working copy)
> @@ -68,6 +68,7 @@
>          acid[4] = 0;
>          cid = strtol(acid, NULL, 16);
>          st->codec->codec_id = codec_get_id(codec_wav_tags, cid);
> +        st->need_parsing = AVSTREAM_PARSE_FULL;
>      }
>  
>      p += 4;                     /* useless size field */

Am I correct to assume that there is no way to tell when the parsing
is actually needed?  If the answer is yes, the patch is OK.  Either
way, do you have a sample?

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list