[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [4/7] - G.729 core

[Vladimir Voroshilov]

2008/5/18 The Wanderer <inverseparadox at comcast.net>:
> Diego Biurrun wrote:
>
>> On Sun, May 18, 2008 at 12:15:56AM +0700, Vladimir Voroshilov wrote:
>>>
>>> Next update.
>>>
>>> --- /dev/null
>>> +++ b/libavcodec/g729.h
>>> @@ -0,0 +1,137 @@
>>> +#define FC_SIGNS_BITS_8K     4  ///< fixed codebook signs, 8k mode (size in bits)
>>> +#define FC_INDEXES_BITS_8K   13 ///< fixed codebook indexes, 8k mode (size in bits)
>>> +#define FC_SIGNS_BITS_4K4    4  ///< number of pulses in fixed-codebook vector, 4.4k mode
>>
>> Sometimes you write "fixed codebook", sometimes "fixed-codebook".
>> Settle on one spelling.  Mans or the Wanderer will advise you which
>> way is preferred.
>
> Actually, these two forms mean different things.
>
> "fixed codebook signs" means "codebook signs which are fixed".
>
> "fixed-codebook vector" means "(the) vector associated with the fixed
> codebook".
>

[...]

Thsnk you for good explanation.
I meant "fixed-codebook" everywhere.

Updated patch attached.

-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 04_g729dec_58.diff
Type: text/x-diff
Size: 30310 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080524/04c176e9/attachment.diff>