[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [5/7] - G.729 tables

Vladimir Voroshilov voroshil
Sat May 24 11:01:37 CEST 2008


2008/5/18 Vladimir Voroshilov <voroshil at gmail.com>:
> 2008/5/18 Michael Niedermayer <michaelni at gmx.at>:
>> On Sun, May 18, 2008 at 12:17:19AM +0700, Vladimir Voroshilov wrote:
>>> 2008/5/10 Michael Niedermayer <michaelni at gmx.at>:
>>> > On Fri, May 02, 2008 at 06:47:03PM +0700, Vladimir Voroshilov wrote:
>>> >> Patch contains G.729 lookup tables.
>>> >>
>>> >>
>>> >> --
>>> >> Regards,
>>> >> Vladimir Voroshilov mailto:voroshil at gmail.com
>>> >> JID: voroshil at gmail.com, voroshil at jabber.ru
>>> >> ICQ: 95587719
>>> >
>>> >> diff --git a/libavcodec/g729tab.c b/libavcodec/g729tab.c
>>> >> new file mode 100644
>>> >> index 0000000..747d458
>>> >> --- /dev/null
>>> >> +++ b/libavcodec/g729tab.c
>>> >
>>> > The tables used from just a single c file should be static.
>>>
>>> What about g729tab.c -> g729data.h
>>> and convert all mebers to static?
>>
>> You are aware that you cannot #include this file in more than a single
>> C file ...
>> If yes then g729data.h is fine.
>
> Sure, i am.

Here is current patch.

-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 05_g729tab_58.diff
Type: text/x-diff
Size: 16514 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080524/37308201/attachment.diff>



More information about the ffmpeg-devel mailing list