[FFmpeg-devel] [PATCH] Some ra144.c simplifications

[Vitor Sessak]

Hi

Michael Niedermayer wrote:
> On Sun, May 11, 2008 at 05:45:29PM +0200, Vitor Sessak wrote:
>> Michael Niedermayer wrote:
>>> On Sat, May 10, 2008 at 04:50:03PM +0200, Vitor Sessak wrote:
>>>> Hi,
>>>>
>>>> libavcodec/ra144.c really needs some cleanup. I'll start with the following:
>>>>
>>>> ra144_indent.diff: Reindent the whole file. Since there was no
>>>> substantial change in this file since it inclusion in 2003, I don't
>>>> think there is any problem in making its indentation inline with the
>>>> rest of FFmpeg.
>>>>
>>>> ra144_unpack_rewrite.diff: Rewrite completely unpack_input()
>>>>
>>>> ra144_simp{1,2}.diff: minor simplifications
>>> all ok if you have tested your code
>> Next round:
>>
>> ra144_simp{3,4}.diff: minor simplifications (FFSWAP, unused stuff removal)
>
> ok
>
>
>> ra144_sqrt.diff: remove ff_sqrt reimplementation and its corresponding
>> big table (output is not anymore binary-identical but this function is
>> more accurate, not less). Nice thing we have now a fast ff_sqrt :-)
>
> by how much does the output differ?

I found a way to keep it binary identical. ra144_sqrt2.diff.

Also ra144_decode_frame_loop.diff simplifies ra144_decode_frame()
unrolling a senseless loop (thanks mkhodor for the suggestion).

-Vitor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ra144_decode_frame_loop.diff
Type: text/x-diff
Size: 1620 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080521/2aa84ce0/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ra144_sqrt2.diff
Type: text/x-diff
Size: 32029 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080521/2aa84ce0/attachment-0001.diff>