[FFmpeg-devel] [PATCH] Fix leak in mov.c

Baptiste Coudurier baptiste.coudurier
Wed May 21 00:59:12 CEST 2008


Hi,

Albert Astals Cid wrote:
> [...]
>
>      atom.type = MKTAG('m','o','o','v');
>      atom.offset = 0;
>      atom.size = moov_len;
> @@ -1603,6 +1603,10 @@
>      av_log(c->fc, AV_LOG_ERROR, "this file requires zlib support compiled in\n");
>      return -1;
>  #endif
> +error:
> +    av_free(moov_data);
> +    av_free(cmov_data);
> +    return -1;
>  }
>  

Code must be under #ifdef CONFIG_ZLIB, otherwise it is just dead code.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA




More information about the ffmpeg-devel mailing list