[FFmpeg-devel] [PATCH]support for chapters in mkv container

[Anton Khirnov]

On Sun, May 18, 2008 at 7:01 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
>
> I agree with this, and I'm not against a public API in general.
> I'm just slightly against a public API which makes it slightly
> harder to add new fields in AVChapter.
> The easiest way to solve this now is to make this function
> non-public. This don't prevent adding a public function later.
> Another solution is to improve this function so that it can
> support inserting new fields in AVChapter without API change.
>

Ok, but I left it in avformat.h, because I don't know where else to put it.
We could also let the caller fill all the fields for himself and then
just pass a pointer to the chapter, but that kind of makes
av_new_chapter useless, doesn't it?

Anton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: chapters_lavf.diff
Type: text/x-diff
Size: 2541 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080519/f9bbf615/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: chapters_mkv.diff
Type: text/x-diff
Size: 7495 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080519/f9bbf615/attachment-0001.diff>