[FFmpeg-devel] [PATCH] fix $(PREFIX) references in pkgconfig files

[Anssi Hannula]

M?ns Rullg?rd wrote:
> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>> On date Tuesday 2008-05-06 08:46:58 +0300, Anssi Hannula encoded:
>>> By default $libdir and $incdir reference $(PREFIX), which in .pc files
>>> should be ${prefix}.
>>>
>>> I'm not sure of the best way to handle this, but attached is a simple
>>> patch sed'ing the .pc files.
[...]
>>>  EOF
>>> +apply $name.pc sed s,\$\(PREFIX\),\${prefix},
>>>  cat <<EOF >$name-uninstalled.pc
>>>  prefix=
>>>  exec_prefix=
>> Hi, please could you fix it, this breaks commandlines/Makefiles using
>> pkg-config and libav.
> 
> I am strongly tempted to remove all direct pkg-config support in
> FFmpeg, and let those who want such files create them for themselves.

Until you do that, I'd suggest to apply or comment on the attached patches:

pkgconfig-static-only-builds.patch:
The patch from the other thread, i.e. define private libraries as
'Libs:' when only static libraries are built,so that they work correctly
even without pkgconfig's --static option. The users of libav* should not
have to care whether libav* is static or shared.

pkgconfig-private-requires.patch:
When the shared libraries are built, make the requires Requires.private,
as the libav* user does not need to link against those (i.e. the same we
did for Libs earlier).

pkgconfig-reformat-prefix.patch:
The patch of this thread, rediffed so that it applies after the above
two. Our default $libdir and $incdir reference $(PREFIX), which should
be ${prefix} in .pc files.

-- 
Anssi Hannula
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pkgconfig-private-requires.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080518/8bd14ed8/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pkgconfig-reformat-prefix.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080518/8bd14ed8/attachment.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: pkgconfig-static-only-builds.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080518/8bd14ed8/attachment-0001.txt>