[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [4/7] - G.729 core

[Diego Biurrun]

On Sun, May 18, 2008 at 12:15:56AM +0700, Vladimir Voroshilov wrote:
> 
> Next update.
> 
> --- /dev/null
> +++ b/libavcodec/g729.h
> @@ -0,0 +1,137 @@
> +#define FC_SIGNS_BITS_8K     4  ///< fixed codebook signs, 8k mode (size in bits)
> +#define FC_INDEXES_BITS_8K   13 ///< fixed codebook indexes, 8k mode (size in bits)
> +#define FC_SIGNS_BITS_4K4    4  ///< number of pulses in fixed-codebook vector, 4.4k mode

Sometimes you write "fixed codebook", sometimes "fixed-codebook".
Settle on one spelling.  Mans or the Wanderer will advise you which way
is preferred.

> +    uint8_t fc_indexes_bits;  ///< Size (in bits) of fixed codebook index entry

size

> --- /dev/null
> +++ b/libavcodec/g729dec.c
> @@ -0,0 +1,674 @@
> +    int16_t gain_pitch;         ///< (Q14) Pitch gain of previous subframe (3.8) [SHARP_MIN ... SHARP_MAX]

pitch

> +    int16_t gain_code;          ///< (Q1) Gain code of previous subframe

gain

> +    /// (Q0) Residual signal buffer (used in long-term postfilter)

residual

> +        av_log(avctx, AV_LOG_ERROR, "Only mono sound is supported (requested channels:%d)\n", avctx->channels);

I think there should be a space after the colon.

> +       Pitch gain of previous subframe.

lowercase, no period; there is no verb.

> +        /* Call postfiltering and also update voicing decision for use in next frame */

postfilter

> + * \brief Decodes one G.729 frame (10 bytes long) into parameters vector.

parameter vector

> + * \param parm [out] decoded parameters of the codec

decoded codec parameters

Diego