[FFmpeg-devel] [PATCH] Improve eval.c:parse_primary() error message

[Michael Niedermayer]

On Sat, May 17, 2008 at 05:48:37PM +0200, Stefano Sabatini wrote:
> Hi, as in subject.
> 
> BTW, I wonder, there is a particular reason for not using bison/some
> other equivalent tool for these kind of parsings (it could be useful
> also for the ffserver.conf file and for the filter graph)?
> 
> (Maybe are you simply trying to avoid to depend on those other tools?)
> 
> Regards.
> -- 
> FFmpeg = Free and Frenzy MultiPurpose EnGine

> Index: libavcodec/eval.c
> ===================================================================
> --- libavcodec/eval.c	(revision 13187)
> +++ libavcodec/eval.c	(working copy)
> @@ -217,7 +217,7 @@
>  
>      p->s= strchr(p->s, '(');
>      if(p->s==NULL){
> -        *p->error = "missing (";
> +        *p->error = "not a named constant and not a function since it is missing '('";

i think
"undefined constant or missing ("
is better

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080517/f18073c9/attachment.pgp>