[FFmpeg-devel] [PATCH] Add ADPCM codec long_names

[Stefano Sabatini]

On date Wednesday 2008-05-14 01:46:40 +0200, Aurelien Jacobs encoded:
> Stefano Sabatini wrote:
> 
> > Hi, as in subject,
> > 
> > please especially maintainers comment on the choice of the long_name
> > for your maintained codecs.
> >
> > [...]
> > 
> > Index: libavcodec/adpcm.c
> > ===================================================================
> > --- libavcodec/adpcm.c	(revision 13150)
> > +++ libavcodec/adpcm.c	(working copy)
> > @@ -1594,7 +1594,7 @@
> >  
> >  
> >  #ifdef CONFIG_ENCODERS
> > -#define ADPCM_ENCODER(id,name)                  \
> > +#define ADPCM_ENCODER(id,name,_long_name)       \
> 
> Identifiers starting with an _ are reserved by the C language.
> So please avoid them.
> 
> > +ADPCM_DECODER(CODEC_ID_ADPCM_SBPRO_2, adpcm_sbpro_2, "Sound Blaster Pro 2 ADPCM");
> 
> Sound Blaster Pro 2 bits ADPCM
> 
> > +ADPCM_DECODER(CODEC_ID_ADPCM_SBPRO_3, adpcm_sbpro_3, "Sound Blaster Pro 3 ADPCM");
> 
> Sound Blaster Pro 2.6 bits ADPCM
> 
> > +ADPCM_DECODER(CODEC_ID_ADPCM_SBPRO_4, adpcm_sbpro_4, "Sound Blaster Pro 4 ADPCM");
> 
> Sound Blaster Pro 4 bits ADPCM

Fixed, thanks for the review.

Regards.
-- 
FFmpeg = Furious Free Multimedia Portentous ExchanGer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-adpcm-long-names-01.patch
Type: text/x-diff
Size: 4927 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080514/7e7d2547/attachment.patch>