[FFmpeg-devel] [PATCH] Fix av_set_string()

[Michael Niedermayer]

On Tue, May 13, 2008 at 12:38:34AM +0200, Stefano Sabatini wrote:
> On date Monday 2008-05-12 22:44:35 +0200, Michael Niedermayer encoded:
> > On Mon, May 12, 2008 at 10:22:32PM +0200, Stefano Sabatini wrote:
> > > Hi all,
> > > as in subject.
> > > 
> > > Best regards.
> > > -- 
> > > FFmpeg = Free and Foolish MultiPurpose EnGine
> > 
> > > Index: libavcodec/opt.c
> > > ===================================================================
> > > --- libavcodec/opt.c	(revision 13138)
> > > +++ libavcodec/opt.c	(working copy)
> > > @@ -172,8 +172,8 @@
> > >                  else if(!strcmp(buf, "none"   )) d= 0;
> > >                  else if(!strcmp(buf, "all"    )) d= ~0;
> > >                  else {
> > > -                    if (!error)
> > > +                    if (error)
> > 
> > ok
> > 
> > 
> > > -                        av_log(NULL, AV_LOG_ERROR, "Unable to parse option value \"%s\": %s\n", val, error);
> > > +                        av_log(NULL, AV_LOG_ERROR, "Unable to parse option value \"%s\": %s\n", buf, error);
> > 
> > not ok
> [...]
> 
> I agree they are two different issues, so I'm splitting the patch.
> 
> Regards.
> -- 
> FFmpeg = Foolish and Freak MultiPurpose EntanGlement

> Index: libavcodec/opt.c
> ===================================================================
> --- libavcodec/opt.c	(revision 13138)
> +++ libavcodec/opt.c	(working copy)
> @@ -172,7 +172,7 @@
>                  else if(!strcmp(buf, "none"   )) d= 0;
>                  else if(!strcmp(buf, "all"    )) d= ~0;
>                  else {
> -                    if (!error)
> +                    if (error)
>                          av_log(NULL, AV_LOG_ERROR, "Unable to parse option value \"%s\": %s\n", val, error);

ok

[....]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080513/20673193/attachment.pgp>