[FFmpeg-devel] [PATCH] Some ra144.c simplifications

[Vitor Sessak]

Michael Niedermayer wrote:
> On Sat, May 10, 2008 at 04:50:03PM +0200, Vitor Sessak wrote:
>> Hi,
>>
>> libavcodec/ra144.c really needs some cleanup. I'll start with the 
>> following:
>>
>> ra144_indent.diff: Reindent the whole file. Since there was no
>> substantial change in this file since it inclusion in 2003, I don't
>> think there is any problem in making its indentation inline with the
>> rest of FFmpeg.
>>
>> ra144_unpack_rewrite.diff: Rewrite completely unpack_input()
>>
>> ra144_simp{1,2}.diff: minor simplifications
> 
> all ok if you have tested your code

Next round:

ra144_simp{3,4}.diff: minor simplifications (FFSWAP, unused stuff removal)

ra144_sqrt.diff: remove ff_sqrt reimplementation and its corresponding
big table (output is not anymore binary-identical but this function is
more accurate, not less). Nice thing we have now a fast ff_sqrt :-)

ra144_do_voice.diff: simplify do_voice()

ra144_split_val.diff: glob->val is unrelated with the rest of the
unpacked buffer. This patch split its table out of the others and move
it parsing to a more reasonable place.

-Vitor

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ra144_simp3.diff
Type: text/x-patch
Size: 749 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080511/8259c1b4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ra144_simp4.diff
Type: text/x-patch
Size: 1610 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080511/8259c1b4/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ra144_sqrt.diff
Type: text/x-patch
Size: 30977 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080511/8259c1b4/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ra144_do_voice.diff
Type: text/x-patch
Size: 871 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080511/8259c1b4/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ra144_split_val.diff
Type: text/x-patch
Size: 5857 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080511/8259c1b4/attachment-0004.bin>