[FFmpeg-devel] [PATCH] Silence useless icc warnings

[Måns Rullgård]

Carl Eugen Hoyos <cehoyos at ag.or.at> writes:

> Hi!
>
> M?ns Rullg?rd <mans <at> mansr.com> writes:
>
>> > Index: configure
>> > ===================================================================
>> > --- configure   (revision 13113)
>> > +++ configure   (working copy)
>> > @@ -1784,8 +1784,19 @@
>> >  enabled debug && add_cflags -g"$debuglevel"
>> >
>> >  # add some useful compiler flags if supported
>> > +check_cflags -Wall
>> > +if $cc --version | grep -q Intel; then
>> > +  # Just warnings, no remarks
>> > +  check_cflags -w1
>> > +  # -wd: Disable following warnings
>> > +  # 144, 167, 556: -Wno-pointer-sign
>> > +  # 10006: ignoring unknown option -fno-signed-zeros
>> > +  check_cflags -wd144,167,556,10006
>> > +  # 10156: ignoring option '-export'; no argument required
>> > +  # 11030: Warning unknown option --as-needed
>> > +  check_ldflags -wd10156,11030
>> > +else
>> >  check_cflags -Wdeclaration-after-statement
>> > -check_cflags -Wall
>> >  check_cflags -Wno-switch
>> >  check_cflags -Wdisabled-optimization
>> >  check_cflags -Wpointer-arith
>> > @@ -1795,6 +1806,7 @@
>> >  check_cflags -Wwrite-strings
>> >  check_cflags -Wtype-limits
>> >  enabled extra_warnings && check_cflags -Winline
>> > +fi
>> 
>> On second thought, your first approach was probably better.
>
> ;-)
>
> I applied a variant of the first approach.
>
> The remaining possible useless warning when compiling with icc is now:
>
> libavcodec/gif.c(343): warning #188: enumerated type mixed with another type
>       .pix_fmts= (enum PixelFormat[]){PIX_FMT_PAL8, -1},
>                                                     ^
>
> Does anybody wants them to be fixes (there are a lot of them) or should I
> silence this warning as well?

These can be fixed by replacing the -1 with PIX_FMT_NONE, which
incidentally has the value -1.

-- 
M?ns Rullg?rd
mans at mansr.com