[FFmpeg-devel] [PATCH] Replace hardcoded LP filter order with parameter in lsp.c
Diego Biurrun
diego
Sun May 11 13:27:32 CEST 2008
On Sun, May 11, 2008 at 12:25:53PM +0100, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
>
> > On Sun, May 11, 2008 at 09:28:25AM +0700, Vladimir Voroshilov wrote:
> >>
> >> This should be better.
> >>
> >> --- a/libavcodec/lsp.c
> >> +++ b/libavcodec/lsp.c
> >> @@ -28,30 +28,30 @@
> >>
> >> - for(i=0; i<9; i++)
> >> + for(i=0; i<lp_order-1; i++)
> >
> > Nit: Can we maybe get an extra space after the ';' there? :)
>
> There are already spaces after the ;. Some of the other operators
> could sure use some surrounding spaces though.
Doh, not in this example, but I'm sure there were cases in this patch
where a space was added only after the second, not the first, semicolon.
Diego
More information about the ffmpeg-devel
mailing list