[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [1/7] - filters

[Vladimir Voroshilov]

2008/5/11 Michael Niedermayer <michaelni at gmx.at>:
> On Sun, May 11, 2008 at 10:55:03AM +0700, Vladimir Voroshilov wrote:
>> 2008/5/11 Vladimir Voroshilov <voroshil at gmail.com>:
>> > 2008/5/10 Michael Niedermayer <michaelni at gmx.at>:
>> >> On Sat, May 10, 2008 at 12:44:25PM +0700, Vladimir Voroshilov wrote:
>> >>> 2008/5/10 Michael Niedermayer <michaelni at gmx.at>:
>> >>> > On Fri, May 09, 2008 at 01:35:31PM +0700, Vladimir Voroshilov wrote:
>> >>>
>> >>> [...]
>> >>>
>> >>> >> +    /* Since there are few pulses over all subframe (i.e. almost all
>> >>> >> +       fc_in[i] are zero, in case of G.729D it is only two non-zero
>> >>> >> +       samples of total 40), it is faster to swap two loops and process
>> >>> >> +       non-zero samples only. This will reduce number of multiplications
>> >>> >> +       from 40*40 to 2*40 for G.729D */
>> >>> >
>> >>> > didnt you want to change this?
>> >>>
>> >>> Is clarification in attached patch ok ?
>> >>
>> >> yes
>> >>
>> >
>> > Here is the latest version.
>> > I'll apply it with a clear head right after awakening.
>> >
>>
>> Damn. I've commited not latest revision.
>> Is it ok to commit fix (only comments are affected, about 15 lines)
>> instead of reverting entire commit?
>
> ok

Fixed.

-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719