[FFmpeg-devel] [PATCH] Remove comparison of unsigned variable with zero

Michael Niedermayer michaelni
Sun May 11 12:01:49 CEST 2008


On Sun, May 11, 2008 at 11:46:24AM +0200, Luca Abeni wrote:
> Hi,
>
> Carl Eugen Hoyos wrote:
> [...]
>> dest_addr_len in udp.c is defined as size_t which is unsigned (if I 
>> googled that correctly). Attached patch removes a comparison of 
>> dest_addr_len with zero (fixes a warning when compiling with icc).
> [...]
> As I wrote in the previous email, I do not think that removing the error 
> check is a good idea.
> I have never seen this warning (even gcc 4.1 does not complain), but I 
> think the attached patches are a better solution (I have no opinions about 
> which one is better, so I attach all the three patches).
>
>
> 				Luca

[...]
> Index: libavformat/udp.c
> ===================================================================
> --- libavformat/udp.c	(revision 13104)
> +++ libavformat/udp.c	(working copy)
> @@ -51,7 +51,7 @@
>  #else
>      struct sockaddr_storage dest_addr;
>  #endif
> -    size_t dest_addr_len;
> +    int dest_addr_len;
>  } UDPContext;
>  
>  #define UDP_TX_BUF_SIZE 32768

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080511/08fd4c52/attachment.pgp>



More information about the ffmpeg-devel mailing list