[FFmpeg-devel] [PATCH] ff_shift (left shift with allowed negative offset) implementation

Vladimir Voroshilov voroshil
Sun May 11 04:45:56 CEST 2008


2008/5/11 Michael Niedermayer <michaelni at gmx.at>:
> On Sat, May 10, 2008 at 11:49:25PM +0700, Vladimir Voroshilov wrote:
>> 2008/5/10 Michael Niedermayer <michaelni at gmx.at>:
>> > On Sat, May 10, 2008 at 08:42:09PM +0700, Vladimir Voroshilov wrote:
>> >> 2008/5/10, Michael Niedermayer <michaelni at gmx.at>:
>>
>> [...]
>>
>> >> > and the name is not good, it should give some hint that offset is meant
>> >> > leftward and that value is signed.
>> >>
>> >> the given name is the best a can invent for it.
>> >> Please anybody suggest better.
>> >
>> > ff_bidir_sal makes sense to me but iam not sure if it makes sense to anyone
>> > else (ones not knowing x86 asm), sal being shift arithmetic (signed) left.
>> >
>> > maybe someone else has a better suggestion
>>
>> ff_shl_bidir ?
>
> shl == unsigned shift to me
>

Then i don't see anything better than yours.



-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ff_shift3.diff
Type: text/x-diff
Size: 684 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080511/e43ce344/attachment.diff>



More information about the ffmpeg-devel mailing list