[FFmpeg-devel] [PATCH] Silence useless icc warnings

[Måns Rullgård]

Carl Eugen Hoyos <cehoyos at ag.or.at> writes:

> Hi!
>
> Michael Niedermayer <michaelni <at> gmx.at> writes:
>
>> On Sat, May 10, 2008 at 11:37:02AM +0200, Carl Eugen Hoyos wrote:
>
> [...]
>
>> > +  check_cflags -w1
>> > +  check_cflags -wd144,167,556,10006,10156
>> > +  check_ldflags -wd10156,11030
>> 
>> These numbers dont say anything to me, doesnt ICC have some options with
>> spelled out names?
>
> Not for warnings, AFAICS.
>
>> If not there should be comments explaining what warnings exactly these
>> disable
>
> Following is a version which does this, sorry that it is inlined, I'm rather
> far away from my own computer.
>
> Please comment, Carl Eugen
>
> Index: configure
> ===================================================================
> --- configure   (revision 13104)
> +++ configure   (working copy)
> @@ -1815,6 +1815,19 @@
>  check_cflags -fno-math-errno
>  check_cflags -fno-signed-zeros
>
> +# add some flags for Intel C Compiler
> +if `$cc --version |grep -q Intel`; then

I prefer the $(command) syntax, and the command could use a little
whitespace cosmetics.

> +  # Just warnings, no remarks
> +  check_cflags -w1
> +  # -wd: Disable following warnings
> +  # 144, 167, 556: -Wno-pointer-sign
> +  # 10006: ignoring unknown option -fno-signed-zeros
> +  # 10156: ignoring option '-W'; no argument required
> +  check_cflags -wd144,167,556,10006,10156
> +  # 11030: ignoring option '-export'; no argument required
> +  check_ldflags -wd10156,11030

Wouldn't it be better to not pass those options in the first place?

> +fi
> +
>  # PIC flags for shared library objects where they are needed
>  if enabled shared; then
>      # LIBOBJFLAGS may have already been set in the OS configuration
>

-- 
M?ns Rullg?rd
mans at mansr.com