[FFmpeg-devel] [PATCH] Silence useless icc warnings

[Måns Rullgård]

Benoit Fouet <benoit.fouet at purplelabs.com> writes:

> Carl Eugen Hoyos wrote:
>> Hi!
>>
>> Attached patch silences most icc warnings.
>> Please comment.
>>
>> Thank you, Carl Eugen
>> ------------------------------------------------------------------------
>>
>> Index: configure
>> ===================================================================
>> --- configure	(revision 13104)
>> +++ configure	(working copy)
>> @@ -1815,6 +1815,13 @@
>>  check_cflags -fno-math-errno
>>  check_cflags -fno-signed-zeros
>>  
>> +# add flags to silence some icc warnings
>> +if test `basename $cc` = "icc"; then
>>   
>
> IIRC, using basename is not good (cannot remember why, though)
> you should use (if I'm correct :) ):
> if test ${cc##*/} = "icc"

Why?  More importantly though, I think it's bad to assume that the
Intel compiler is always called icc, and that no other compiler can go
by that name.

-- 
M?ns Rullg?rd
mans at mansr.com