[FFmpeg-devel] [PATCH]support for chapters in mkv container

[Anton Khirnov]

On Fri, May 9, 2008 at 4:40 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> the changes to matroska and the changes to avformat/utils should be in
> seperate patches.
done


>
> indention is 4 spaces in ffmpeg
>
fixed


>
> The design is bad.
> First adding fields to AVChapter would always require a major version bump
> this is not acceptable, see AVProgram for example.
> Second i think we should come up with some simple clean and generic way to
> handle metadata instead of adding dozens of identical fields to
>    AVFormatContext (for per file metadata)
>    AVStream (for per stream metadata)
>    AVProgram (for per program metadata)
>    AVChapter (for per chapter metadata)
>

Better? As for generic solution - sure, it would be great. Any bright ideas? :)

Anton
-------------- next part --------------
A non-text attachment was scrubbed...
Name: chapters_lavf.diff
Type: text/x-diff
Size: 1436 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080509/def9a658/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: chapters_mkv.diff
Type: text/x-diff
Size: 9009 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080509/def9a658/attachment-0001.diff>