[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [2/7] - pitch lag decoding

Vladimir Voroshilov voroshil
Fri May 9 08:31:02 CEST 2008


Michael Niedermayer wrote: 
> On Fri, May 02, 2008 at 06:36:34PM +0700, Vladimir Voroshilov wrote:

[...]

> > +        int subframeno,
> > +        int pitch_lag_min)
> > +{
> > +    // (4.1.3 of G.729 and 5.6.1 of AMR)
> > +    if (!subframeno)
> > +        return decode_lag3_1st_8_bits(ac_index);
> > +    else
> > +        return 3*pitch_lag_min + ac_index - 1;
> > +}
> 
> It seems as if it would be simpler to do the if (!subframeno) check outside
> after all its always doing the same, this would also avoid having to pass
> subframeno as argument.

See patch.

 
-- 
Regards,
Vladimir Voroshilov mailto:voroshil at gmail.com
Omsk State University
JID: voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02_acelp_lag43.diff
Type: text/x-diff
Size: 14199 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080509/dd4f4b70/attachment.diff>



More information about the ffmpeg-devel mailing list