[FFmpeg-devel] [PATCH] Properly check for sys/resource.h

François Revol revol
Wed May 7 11:05:28 CEST 2008


> Diego Biurrun wrote:
> > On Wed, May 07, 2008 at 09:32:19AM +0100, Ramiro Polla wrote:
> >> $subj
> >>
> >> --- ffmpeg.c	(revision 13058)
> >> +++ ffmpeg.c	(working copy)
> >> @@ -36,7 +36,9 @@
> >>  
> >> -#if !defined(HAVE_GETRUSAGE) && defined(HAVE_GETPROCESSTIMES)
> >> +#ifdef HAVE_SYS_RESOURCE_H
> > 
> > Has the check for getrusage become redundant now?
> 
> Kind of... Having sys/resource.h doesn't imply having getrusage(). I 
> suppose the getrusage check could be removed afterwards. But then we 
> call getrusage() under ifdef HAVE_SYS_RESOURCE_H?
> 

Indeed having the header doesn't mean the function is there or works 
correctly.

Fran?ois.




More information about the ffmpeg-devel mailing list