[FFmpeg-devel] [PATCH] avoid sourcefile inclusion (vis and mlib in swscale)

[Diego Biurrun]

On Mon, May 05, 2008 at 12:43:01PM +0200, Michael Niedermayer wrote:
> On Mon, May 05, 2008 at 12:08:12PM +0200, Diego Biurrun wrote:
> > On Sun, May 04, 2008 at 10:48:20PM +0200, Luca Barbato wrote:
> > > Diego Biurrun wrote:
> > > > 
> > > > Mind alphabetical order and alignment please.
> > > 
> > > Reordered in a second patch
> > 
> > Sorry, but this is complete nonsense.  There is no value in you
> > documenting your ABC troubles in the Subversion history.  On the
> > contrary, now we have an extra revision cluttering the log without any
> > value whatsoever and we will get another when I restore the looks of the
> > Makefile back to my liking.
> 
> Just revert with svn cp from a past revission :)

That will make it worse:

r1: commit
r2: mess up
r3: restore (law and) order

vs.

r1: commit
r2: mess up
r3: revert
r4: recommit properly

i.e. even more clutter.  What I want is

r1: commit taking review comments into account

and more should really not be needed.

> > I have woken up ill-tempered today, 
> 
> I hope you also have a shotgun and a raised floor? ;)

I'm more oldschool.  I bought a shovel and started digging a ditch in my
backyard...

Diego