[FFmpeg-devel] [PATCH] Remove two 'comparison always false' warnings in libavformat

Diego 'Flameeyes' Pettenò flameeyes
Sun May 4 23:40:11 CEST 2008


Michael Niedermayer <michaelni at gmx.at> writes:

> Iam fine with leaving it as int, unless you explain why it should be
> changed to another type.

It's returning a size_t value, int might not be big enough to contain
the size, so there is the chance of an overflow if the value returned is
bigger than int_max. ssize_t should be big enough to keep the size _and_
be signed.

-- 
Diego "Flameeyes" Petten?
http://blog.flameeyes.eu/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080504/dc7d578e/attachment.pgp>



More information about the ffmpeg-devel mailing list