[FFmpeg-devel] [PATCH] MMX for Win64

Måns Rullgård mans
Sun May 4 18:05:47 CEST 2008


"Zuxy Meng" <zuxy.meng at gmail.com> writes:

> 2008/5/4 M?ns Rullg?rd <mans at mansr.com>:
>> Jean-Baptiste Kempf <jb at videolan.org> writes:
>>
>> > On Sat, May 03, 2008 at 10:43:13AM +0200, matthieu castet wrote :
>> >> Jean-Baptiste Kempf wrote:
>> >> > Assembler tries to make a pushl value, which is for x86_64 forbidden.
>> >> > Long is 32bit on Win64
>> >> > (http://technet.microsoft.com/en-us/library/bb496995.aspx).
>> >> > ssize_t, however, is portable between both archs."
>> >> >
>> >> Yes but ffmpeg don't run only on win32 and win64. What make you think it
>> >> will work under _all_ arch ?
>> > Why would using ssize_t or size_t break ?
>> >
>> > The only difference between LP64 and LLP64 is the long type.
>> > Using size_t wouldn't break it.
>>
>> It's wrong to use size_t here.  There is no guarantee that size_t
>> is at all suitable.  For instance, it could legally be 64 bits on a
>> 32-bit system, or 32 bits on a 64-bit system.
>
> What about intptr_t?

That's guaranteed to be at least as wide as a pointer.  Since we're
not dealing with pointers here, it is incorrect to use it.  It is
possible to have 32-bit pointers and 64-bit long.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list