[FFmpeg-devel] pkgconfig Cflag includedir: a suggestion

[sean darcy]

For some while ffmpeg has been installing its include files in 
/incdir/libname/, for instance /usr/include/libavcodec/avcodec.h.

But the pkgconfig .pc files point to just /incdir, /usr/include.

These .pc files are generated in configure lines 2127 et seq:

# build pkg-config files

pkgconfig_generate(){
name=$1
comment=$2
version=$3
libs=$4
requires=$5
cat <<EOF >$name.pc
prefix=$prefix
exec_prefix=\${prefix}
libdir=$libdir
includedir=$incdir

Name: $name
Description: $comment
Version: $version
Requires: $requires
Conflicts:
Libs: -L\${libdir} $libs
Cflags: -I\${includedir}
EOF
}

pkgconfig_generate_uninstalled(){
name=$1
shortname=${name#lib}
comment=$2
version=$3
libs=$4
requires=$5
cat <<EOF >$name-uninstalled.pc
prefix=
exec_prefix=
libdir=\${pcfiledir}/$name
includedir=\${pcfiledir}

Name: $name
Description: $comment
Version: $version
Requires: $requires
Conflicts:
Libs: \${libdir}/${LIBPREF}${shortname}${LIBSUF} $libs
Cflags: -I\${includedir}
EOF
}

I suggest that we change both Cflags ( BTW, why does configure create 
_uninstalled_ .pc files?) to:

Cflags: -I\${includedir}/$name

which enables me to build kino.



sean