[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [6/7] - G.729 postfilter

[Diego Biurrun]

On Fri, May 02, 2008 at 06:49:43PM +0700, Vladimir Voroshilov wrote:
> Patch contains G.729 postfilter.
> It was separated due to large size to help reviewing.
> G.729 can produce audible speech even without this postfilter.
> 
> --- /dev/null
> +++ b/libavcodec/g729postfilter.c
> @@ -0,0 +1,704 @@
> +#include <inttypes.h>
> +#include <limits.h>

Something is missing here...

> +    int16_t gain_num,gain_den; //selected signal's gain numenator and denomenator

numeRator, denomInator, same below

> +          This is archived by applying an interpolation filter of legth 33

achieved?

> +                  Compute numinator of pseudo-normalized correlation R'(k)

numerator?

> +    /* 4.2.3, Equation 87, calcuate rh(0)  */

calculate

> +    /* 4.2.3, Equation 87, calcuate rh(1)  */

ditto

> +    //Zero-filling is necessary for tilt--compensation filter.

s/--/-/

> --- /dev/null
> +++ b/libavcodec/g729postfilter.h
> @@ -0,0 +1,99 @@
> +#ifndef FFMPEG_G729_POSTFILTER_H
> +#define FFMPEG_G729_POSTFILTER_H

This is not the filename.

Also, the license header is missing.

Diego