[FFmpeg-devel] [RFC] LPCM 24 bits support

[Baptiste Coudurier]

Baptiste Coudurier wrote:
> Hi,
> 
> M?ns Rullg?rd wrote:
>> Lars T?uber <lars.taeuber at gmx.net> writes:
>>
>>> diff -pur ffmpeg/libavcodec/Makefile ffmpeg.1/libavcodec/Makefile
>>> --- ffmpeg/libavcodec/Makefile	2008-04-19 20:25:42.000000000 +0200
>>> +++ ffmpeg.1/libavcodec/Makefile	2008-04-19 20:27:50.000000000 +0200
>>> @@ -236,6 +236,7 @@ OBJS-$(CONFIG_ZMBV_ENCODER)            +
>>>  
>>>  OBJS-$(CONFIG_PCM_ALAW_DECODER)        += pcm.o
>>>  OBJS-$(CONFIG_PCM_ALAW_ENCODER)        += pcm.o
>>> +OBJS-$(CONFIG_PCM_DVD_DECODER)         += pcm.o
>>>  OBJS-$(CONFIG_PCM_MULAW_DECODER)       += pcm.o
>>>  OBJS-$(CONFIG_PCM_MULAW_ENCODER)       += pcm.o
>>>  OBJS-$(CONFIG_PCM_S8_DECODER)          += pcm.o
>>>
>>> diff -pur ffmpeg/libavformat/mpeg.c ffmpeg.1/libavformat/mpeg.c
>>> --- ffmpeg/libavformat/mpeg.c	2008-03-04 21:54:06.000000000 +0100
>>> +++ ffmpeg.1/libavformat/mpeg.c	2008-04-19 20:27:58.000000000 +0200
>>> @@ -473,7 +473,9 @@ static int mpegps_read_packet(AVFormatCo
>>>          codec_id = CODEC_ID_DTS;
>>>      } else if (startcode >= 0xa0 && startcode <= 0xaf) {
>>>          type = CODEC_TYPE_AUDIO;
>>> -        codec_id = CODEC_ID_PCM_S16BE;
>>> +        /* CODEC_ID_PCM_S16BE will be handled as the 16bit
>>> +           form of CODEC_ID_PCM_DVD */
>>> +        codec_id = CODEC_ID_PCM_DVD;
> 
> Isn't comment still a bit weird ? Maybe not ...
> 

I was about to apply the patch, I updated the comment, bumped minor. I'd
like confirmation. Thanks.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pcm_dvd.patch
Type: text/x-diff
Size: 4900 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080503/50a2edca/attachment.patch>