[FFmpeg-devel] [PATCH] flac demuxer

[Michael Niedermayer]

On Fri, May 02, 2008 at 06:21:35PM -0400, Justin Ruggles wrote:
> Michael Niedermayer wrote:
> > On Mon, Apr 28, 2008 at 12:51:10AM -0400, Justin Ruggles wrote:
> >> Justin Ruggles wrote:
> >>> Hi,
> >>>
> >>> This patch splits out the FLAC demuxer from raw.c.  It has added
> >>> functionality to read the raw FLAC header, including all metadata.  The
> >>> function to read the streaminfo header needs to be shared with the FLAC
> >>> decoder, so it has been put in lavc.
> >>>
> >>> * svn cp libavformat/raw.c libavformat/flacdec.c
> 
> Here is a patch just to create a new flac demuxer file by copying the
> relevant functions from raw.c.  Each function will be modified later to
> be more specific to FLAC instead of the current generic raw demuxing.

copying (code duplication), and later changing part of it really sounds
ugly and wrong.

If you want to split raw.c that surely can be done without any code
clone and mutate, also spliting raw.c has nothing to to with flac.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080503/f036f3de/attachment.pgp>