[FFmpeg-devel] [PATCH] Use strcasecmp rather than reinventing the loop

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Fri, May 02, 2008 at 07:50:34PM +0200, Diego 'Flameeyes' Petten? wrote:
>> M?ns Rullg?rd <mans at mansr.com> writes:
>> 
>> > Not that I care, but strcasecmp() is not in C99.  It's a POSIX extension.
>> > Prepare for complaints if this is applied.
>> 
>> I've checked first if libavformat was using strcasecmp before, as I
>> suspected this to come up: rtsp.c, mp3.c and utils.c already use it. As
>> do libavdevice, vhook (I know it's deprecated) and ffserver.

You still need to add the necessary #include line.

> Also dont forget considering locale dependancies with what is upper and
> lower case ...

toupper() and tolower() already have the same locale dependencies, so
there's no change in that regard.

-- 
M?ns Rullg?rd
mans at mansr.com