[FFmpeg-devel] [PATCH] Common ACELP code & G.729 [2/7] - pitch lag decoding

[Diego Biurrun]

On Fri, May 02, 2008 at 06:36:34PM +0700, Vladimir Voroshilov wrote:
> This patch contains pitch lag decoding routines (according to different
> encoding schemes).
> --- /dev/null
> +++ b/libavcodec/acelp_pitch_lag.c
> @@ -0,0 +1,97 @@
> +static int decode_lag3_1st_8_bits(int ac_index)
> +{
> +    ac_index += 59;
> +    if(ac_index > 255)
> + [...]
> +    // (4.1.3 of G.729 and 5.6.1 of AMR)
> +    if (!subframeno)

You inconsistently use 'if(' and 'if ('.

> --- /dev/null
> +++ b/libavcodec/acelp_pitch_lag.h
> @@ -0,0 +1,175 @@
> +
> +/// Minimum pitch lag

lowercase

> +/// Maximum pitch lag

lowercase

> +/**
> + * \brief Decode pitch lag with 1/3 precision

Please end sentences in a period.

> + * \return 3*pitch_delay+1

This could be more readable with a few spaces '3 * pitch_delay + 1',
same below.

> + *    where T1 is pitch lag from previous subframe

.

> + * \remark The routine is used in G.729 @8k, AMR @10.2k, AMR @7.95k, AMR @7.4k

.

> +/**
> + * \brief Decode pitch lag with 1/3 precision

.

> + *    where T1 is pitch lag from previous subframe

.

> + * \remark The routine is used in G.729 @6.4k, AMR @6.7k, AMR @5.9k,
> + *         AMR @5.15k, AMR @4.75k

.

> +/**
> + * \brief Decode pitch lag with 1/6 precision

.

> + * \return 6*pitch_delay+2

see above

> + *    where T1 is pitch lag from previous subframe

.

> + * \remark The routine is used in AMR @12.2k

.

Diego