[FFmpeg-devel] [RFC] LPCM 24 bits support

[Michael Niedermayer]

On Sat, Mar 29, 2008 at 08:25:45PM +0000, Giuliano Pochini wrote:
> On Wed, 26 Mar 2008 00:48:39 +0100
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > On Wed, Mar 26, 2008 at 12:20:13AM +0000, Giuliano Pochini wrote:
> > >      } else if (startcode >= 0xa0 && startcode <= 0xaf) {
> > >          type = CODEC_TYPE_AUDIO;
> > > -        codec_id = CODEC_ID_PCM_S16BE;
> > > +        codec_id = CODEC_ID_PCM_DVD;
> >
> > CODEC_ID_PCM_S16BE should stay CODEC_ID_PCM_S16BE
> 
> My patch also handles that format. If codec_id stays CODEC_ID_PCM_S16BE
> then I have to place the DVD LPCM decoder into the CODEC_ID_PCM_S16BE case
> in pcm.c which doesn't look correct IMHO. Any hints ?

If it is 16bit PCM set CODEC_ID_PCM_S16BE, if it is not set CODEC_ID_DVD_LPCM
or whatever is the correct name.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080330/f90e37b3/attachment.pgp>