[FFmpeg-devel] [PATCH] Escape 124 (RPL) decoder rev2

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Fri, Mar 28, 2008 at 04:57:42PM -0700, Eli Friedman wrote:
>> On Fri, Mar 28, 2008 at 4:11 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
>> >  [...]
>> >  > +static CodeBook* unpack_codebook(GetBitContext* gb, uint32_t depth,
>> >  > +                                 uint32_t length, uint32_t alloc_length) {
>> >  > +    uint32_t i, j;
>> >
>> >  These dont need to be exactly 32 bit, so unsigned (int) seems more appropriate.
>> 
>> They need to be more than 16 bits, so unsigned isn't appropriate.
>
> Quoting POSIX:
> {UINT_MAX}
>
> Maximum value of type unsigned.
> [CX] Minimum Acceptable Value: 4 294 967 295
> ------------
>
> Now if you want your code to run on pre POSIX 16bit systems, you could try

That is not only pre-, but also current non-POSIX systems.  C99
requires a minimum of only 16 bits for int.  It still won't work, of
course.

-- 
M?ns Rullg?rd
mans at mansr.com