[FFmpeg-devel] [FFmpeg-soc] [Patch]GSoC 2008 qualification task TS Muxer

[Michael Niedermayer]

On Wed, Mar 26, 2008 at 12:02:46AM +0800, zhentan feng wrote:
[...]
> >  > The situation is that I just download the codes from
> >  > svn://svn.mplayerhq.hu/soc/dvbmuxer
> >  > and I got 4 files mpegtsenc.c, mpegenc.c,mpegpesenc.c,mpegpes.h,which
> >  > are already bug
> >  > fixed for mpegtsenc.c against the svn-devl codes, and already
> >  > extracted some common codes.
> >  >
> >  > According to  baptiste.coudurie wrote in the early mail,I have just
> >  > extracted more common codes and do not do any functional changes.
> >  > As qualification task, I think I will do the next 2 things:
> >  >
> >  > 1.Test my codes , confirm it works correctly.
> >  > 2.Create different patches for different situation:
> >  >    i) create patches against  svn://svn.mplayerhq.hu/soc/dvbmuxer to
> >  > show my changes from the last year's students.
> >
> >
> > Yes, current TS muxer in soc is working, however mpegtsenc.c and
> >  mpegenc.c in soc svn shares too much code, you can see that already.
> >  Im not sure if code from ffmpeg svn mpegenc.c can be extracted right
> >  now, since It might not fit soc svn mpegtsenc.c code.
> 
> I have created a patch against svn soc and attached below again.
> This is just a draft to show that I think they could be extracted ,but
> it need to do some tricks (such as some NULL pointer, or flag)to make
> both mpegtsenc.c and mpegenc.c can share most of the codes extracted.
> So ,it maybe looks a little ugly :(
> 
> If you agree the changes , I will make it work correctly as soon as possible:)

I will leave review of patches for soc-svn to baptiste.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080325/02648966/attachment.pgp>