[FFmpeg-devel] [PATCH] revision r12484 breaks OS/2

[Diego Biurrun]

On Thu, Mar 20, 2008 at 08:19:43PM +0100, Diego Biurrun wrote:
> On Thu, Mar 20, 2008 at 05:25:51PM +0000, M?ns Rullg?rd wrote:
> > Dave Yeo <daveryeo at telus.net> writes:
> > 
> > > On 03/18/08 03:23 am, M?ns Rullg?rd wrote:
> > >> Dave Yeo wrote:
> > >>> Hi, the patch committed for r12384 breaks OS/2 due to nm.exe not
> > >>> understanding OMF object format.
> > >>> nm --help
> > >>> [...]
> > >>> nm: supported targets: a.out-emx elf32-i386 efi-app-ia32 pe-i386
> > >>> pei-i386 elf32-little elf32-big srec symbolsrec tekhex binary ihex trad-core
> > >>>
> > >>> epm: I:\usr\src\ffmpeg >sh ./configure --enable-gpl --enable-os2threads
> > >>> nm: F:/XFREE86/TMP/ffmpeg-conf--35636-.o: File format not recognized
> > >> The general idea is that your toolset should be working...
> > >
> > > Attached patch makes object files aout (aout-emx) format. Executables
> > > need .exe so ld will create a LX executable instead of an aout
> > > binary. The various tools like nm do understand aout.
> > >
> > > --- configure	(revision 12515)
> > > +++ configure	(working copy)
> > > @@ -871,7 +871,7 @@
> > >  
> > >  TMPC="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.c"
> > >  TMPO="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.o"
> > > -TMPE="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}"
> > > +TMPE="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}$EXESUF"
> > >  TMPS="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.S"
> > >  TMPH="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.h"
> > 
> > This wrong.  EXESUF hasn't been set there.
> 
> But it is probably correct anyway.  I think this should be moved to a
> place where it can pick up $EXESUF.

Changed.

Diego