[FFmpeg-devel] [PATCH] revision r12484 breaks OS/2

[Måns Rullgård]

Dave Yeo <daveryeo at telus.net> writes:

> On 03/18/08 03:23 am, M?ns Rullg?rd wrote:
>> Dave Yeo wrote:
>>> Hi, the patch committed for r12384 breaks OS/2 due to nm.exe not
>>> understanding OMF object format.
>>> nm --help
>>> [...]
>>> nm: supported targets: a.out-emx elf32-i386 efi-app-ia32 pe-i386
>>> pei-i386 elf32-little elf32-big srec symbolsrec tekhex binary ihex trad-core
>>>
>>> epm: I:\usr\src\ffmpeg >sh ./configure --enable-gpl --enable-os2threads
>>> nm: F:/XFREE86/TMP/ffmpeg-conf--35636-.o: File format not recognized
>> The general idea is that your toolset should be working...
>>
>
> Attached patch makes object files aout (aout-emx) format. Executables
> need .exe so ld will create a LX executable instead of an aout
> binary. The various tools like nm do understand aout.
> Dave
> Index: configure
> ===================================================================
> --- configure	(revision 12515)
> +++ configure	(working copy)
> @@ -871,7 +871,7 @@
>  
>  TMPC="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.c"
>  TMPO="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.o"
> -TMPE="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}"
> +TMPE="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}$EXESUF"
>  TMPS="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.S"
>  TMPH="${TMPDIR1}/ffmpeg-conf-${RANDOM}-$$-${RANDOM}.h"

This wrong.  EXESUF hasn't been set there.

> @@ -1268,16 +1268,13 @@
>          ranlib="echo ignoring ranlib"
>          ;;
>      os/2*)
> -        ar="emxomfar -p256"
> -        ranlib="echo ignoring ranlib"
>          strip="lxlite"
>          ln_s="cp -f"
> -        add_cflags "-Zomf"
>          EXESUF=".exe"
>          FFLDFLAGS="-Zomf -Zbin-files -Zargs-wild -Zmap"
>          SHFLAGS='$(NAME).def -Zdll -Zomf'
>          FFSERVERLDFLAGS=""
> -        LIBSUF="_s.lib"
> +        LIBSUF="_s.a"
>          SLIBPREF=""
>          SLIBSUF=".dll"
>          SLIBNAME_WITH_VERSION='$(SLIBPREF)$(NAME)-$(LIBVERSION)$(SLIBSUF)'

I'm all for cruft removal.  Is this certain not to cause any other
problems?  I'd like to think those flags were added for a reason.

-- 
M?ns Rullg?rd
mans at mansr.com