[FFmpeg-devel] [PATCH] remove redundant ARCH_ preprocessor checks

[Diego Biurrun]

On Tue, Mar 18, 2008 at 02:45:37PM +0100, Diego Biurrun wrote:
> On Sat, Mar 15, 2008 at 02:53:59PM +0100, Aurelien Jacobs wrote:
> > On Sat, 15 Mar 2008 11:32:49 +0100
> > Diego Biurrun <diego at biurrun.de> wrote:
> > 
> > > I found a couple of redundant #if ARCH_* checks that enclose things like
> > > HAVE_ALTIVEC and similar more specific checks.  Attached is a patch to
> > > remove them.  I will apply this after the weekend unless I hear
> > > objections.
> > > 
> > > [...]
> > > 
> > > -#if defined(ARCH_X86)
> > > -
> > >  #if (defined (HAVE_MMX) && !defined (HAVE_3DNOW) && !defined (HAVE_MMX2)) || defined (RUNTIME_CPUDETECT)
> > >  #define COMPILE_MMX
> > >  #endif
> > 
> > I think removing this one is wrong, because RUNTIME_CPUDETECT can be
> > defined for non-x86 cpus.
> 
> Yes, thanks for reviewing this.  I'll apply a version without this
> hunk.

Applied.

Diego