[FFmpeg-devel] [PATCH] move ff_emulated_edge_mc() to dsputil

Rich Felker dalias
Wed Mar 5 05:51:25 CET 2008


On Wed, Mar 05, 2008 at 12:14:24AM +0100, Aurelien Jacobs wrote:
> Michael Niedermayer wrote:
> 
> > On Tue, Mar 04, 2008 at 09:16:31PM +0100, Aurelien Jacobs wrote:
> > > Hi,
> > > 
> > > ff_emulated_edge_mc() is used by many non-mpeg codecs, so it don't
> > > belong to mpegvideo.c. It seems to fit pretty well inside dsputil.c.
> > > Is this patch OK ?
> > 
> > Ok, but iam not sure if it is such a good idea to move everything into
> > dsputil.c ...
> 
> I thought about this too. But I found no better place to move those
> functions to (except creating a new file for each one of those function).
> Anyway, this is not everything. This was only 3 functions (yes, this is
> the last one).
> 
> Now, dsputil would be the next target to split/compile conditionally.
> But this looks like a much more painful task...

Splitting dsputil.c and motion_est.c would be a major improvement in
compilability. These files are waaaaaay too big and gcc stupidity
results in very slow and memory-intensive compiling, probably due to
useless searches for global optimizations or something.

Rich




More information about the ffmpeg-devel mailing list