[FFmpeg-devel] [PATCH] VFW capture support
Ramiro Polla
ramiro
Sun Mar 2 23:04:30 CET 2008
Hello,
Attached patch adds VFW capture support for Windows. Tested on MinGW and
IIRC V?ctor said once it kind of worked on Cygwin.
Issues:
- I tried to make the code look as much as possible as the code given in
MSDN, so that means I used "LRESULT CALLBACK" without even knowing what
it does or if it can be removed. I have also used "var == FALSE" and
"var == NULL" checks. I prefer that instead of "!var" just to be closer
to MSDN.
- Some defines are missing from MinGW include headers. I'll try to get
them integrated into MinGW. After that, we can properly check for MinGW
versions to define them, or just plain remove the definitions here and
require a newer version of MinGW. In the meantime, I think there's no
problem in defining them here.
- If no "-r" parameter is given, way too many frames are read. I thought
FFmpeg was supposed to read the first few frames and decide the rate
based on that. The capture blocks, so the timestamps are correct, and if
some frames were captured and then the frame rate calculated, it should
find the correct frame rate, right?
Please review.
Ramiro Polla
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: vfwcap.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080302/0286af6f/attachment.txt>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vfwcap.c
Type: text/x-csrc
Size: 6491 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080302/0286af6f/attachment.c>
More information about the ffmpeg-devel
mailing list